Add NPU to manifest #111
Merged
Add NPU to manifest #111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The problem is that I need to change project.json I could do it ugly and just add npuEnabled as bool or null. However I want to do a clean up and a migration anyway. This commit lays the ground work: - Migrate to new project is either PublicProject or GetiProject - Add migration test for 1.0.0 to 25.0.1 Tests are broken as is. so WIP
This class tries to migrate project jsons on start up It takes the current ManifestJson which is a weakness. Changes in manifestJson format might break future migrations, meaning that we need to be sure that previous migrations keep working. Hense the tests.
…supported model The InferencePage now does a quick async check and sets the device back to default if npu is selected.
1. Show file size properly on public model on load 2. Public models are stored in their ID folders instead of a uuid
RHeckerIntel
requested review from
ArendJanKramer,
ActiveChooN and
AlexanderBarabanov
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #111 +/- ##
==========================================
+ Coverage 30.75% 32.03% +1.27%
==========================================
Files 138 141 +3
Lines 5693 5704 +11
==========================================
+ Hits 1751 1827 +76
+ Misses 3942 3877 -65
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A complicated PR.
Was able to finally do a bit of refactor here since I needed to add the npuEnabled to the manifest and then the project.json.
This meant that I needed to write a migration for older projects.
I took that moment to separate the GetiProject and PublicProject more. Geti projects contain tasks and a public project really wants to have the manifest information in there.
Another thing is that when the user has selected the npu for whisper for example then when the user switches to a computer vision model it should not load it on npu as that is not supported as of right now. In pages/models/inference.dart I added an async check for this since all the info was available for this.